Change in vdsm[master]: ipwrapper: switch link polling to netlink

asegurap at redhat.com asegurap at redhat.com
Wed Jan 15 21:56:42 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: ipwrapper: switch link polling to netlink
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/23248/5/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:

Line 115:     _hiddenNics = config.get('vars', 'hidden_nics').split(',')
Line 116:     _hiddenVlans = config.get('vars', 'hidden_vlans').split(',')
Line 117: 
Line 118:     def __init__(self, address, index, linkType, mtu, name, qdisc, state,
Line 119:                  vlanid=None, vlanprotocol=None, master=None, device=None,
> what is "device"? When is it missing? Why is it suddenly important? Could i
It is the underlying device of a vlan/macvlan. It was already being created by the "fromText" method. I just wanted to make it explicit that it is often passed.
Line 120:                  **kwargs):
Line 121:         self.address = address
Line 122:         self.index = index
Line 123:         self.type = linkType


-- 
To view, visit http://gerrit.ovirt.org/23248
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a120155e3c5be15c237171620e5c996c2af681
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list