Change in vdsm[master]: vdsm.spec: specify sysV commands for EL6 only

danken at redhat.com danken at redhat.com
Wed Jan 15 18:03:51 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: specify sysV commands for EL6 only
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/23235/4/vdsm.spec.in
File vdsm.spec.in:

Line 798:     fi
Line 799: fi
Line 800: exit 0
Line 801: 
Line 802: %if 0%{?rhel}
Actually, this needs to run only iff we configured libvirt to use upstrart (which happens only in el6). so please - keep the current code, and only limit its effectiveness to el6.

You can add a comment:

 # In el6, We configure libvirt to use upststart without the libvirt.rpm's
 # awareness. Thus, we must stop/restart libvirt ourselves when the
 # libvirt.rpm is removed/upgraded.
Line 803: %triggerun -- libvirt
Line 804: if [ "$2" -eq "0" ]; then
Line 805:     %{_bindir}/vdsm-tool service-stop libvirtd > /dev/null 2>&1 || :
Line 806: fi


Line 801: 
Line 802: %if 0%{?rhel}
Line 803: %triggerun -- libvirt
Line 804: if [ "$2" -eq "0" ]; then
Line 805:     %{_bindir}/vdsm-tool service-stop libvirtd > /dev/null 2>&1 || :
this issue should have inflicted Fedora servers, too. how come we did not notice it? I think it deserves its own explanation in its own commit message.
Line 806: fi
Line 807: 
Line 808: %triggerpostun -- libvirt
Line 809: if [ "$2" -ge "1" ]; then


-- 
To view, visit http://gerrit.ovirt.org/23235
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie52ae97d48d795d53529152b68380fbd13d7927d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list