Change in vdsm[master]: gluster: enhance vdsmcli error handling

hchiramm at redhat.com hchiramm at redhat.com
Wed Jan 15 12:41:04 UTC 2014


Humble Devassy Chirammal has posted comments on this change.

Change subject: gluster: enhance vdsmcli error handling
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/23057/1/client/vdsClientGluster.py
File client/vdsClientGluster.py:

Line 416:         params = self._eqSplit(args)
Line 417:         try:
Line 418:             serviceNames = params.get('serviceNames', '').split(',')
Line 419:         except:
Line 420:             raise ValueError
try/except is not required as its not going to return any exception from params.get() or split().
Line 421:         action = params.get('action', '')
Line 422: 
Line 423:         status = self.s.glusterServicesAction(serviceNames, action)
Line 424:         pp.pprint(status)


Line 427:     def do_glusterServicesGet(self, args):
Line 428:         params = self._eqSplit(args)
Line 429:         try:
Line 430:             serviceNames = params.get('serviceNames', '').split(',')
Line 431:         except:
as like above try/except is not required. Also indentation has to be taken care.
Line 432:             raise ValueError
Line 433: 
Line 434:         status = self.s.glusterServicesGet(serviceNames)
Line 435:         pp.pprint(status)


-- 
To view, visit http://gerrit.ovirt.org/23057
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2e29dfb724cf4c8370bf836d64510376df37058a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Humble Devassy Chirammal <hchiramm at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list