Change in vdsm[master]: securable: refactor the securable implementation

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 15 09:51:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: securable: refactor the securable implementation
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/22115/5/vdsm/storage/securable.py
File vdsm/storage/securable.py:

Line 27: class SecureError(RuntimeError):
Line 28:     pass
Line 29: 
Line 30: 
Line 31: def Secured(check_method_name):
> docstring still omitted. intentionally?
I never seen CamelCase decorators in other code, but we have them, e.g. monkeypatch.MonkeyPatch and monkeypatch.MonkeyClass.
Line 32:     def wrapper(cls):
Line 33:         for name, value in cls.__dict__.iteritems():
Line 34:             if (not callable(value) or not getattr(value, SECURE_FIELD, True)
Line 35:                     or name.startswith("__")  # skipping builtins


-- 
To view, visit http://gerrit.ovirt.org/22115
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a8be7536748481746795e27701fbecc7c3318c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list