Change in vdsm[master]: vdsm: fix RTC offset

danken at redhat.com danken at redhat.com
Tue Jan 14 11:19:19 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: fix RTC offset
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/14750/3/vdsm/vm.py
File vdsm/vm.py:

Line 1813:         self._incomingMigrationFinished = threading.Event()
Line 1814:         self.id = self.conf['vmId']
Line 1815:         self._volPrepareLock = threading.Lock()
Line 1816:         self._initTimePauseCode = None
Line 1817:         self._initTimeRTC = long(self.conf['timeOffset'])
> I just checked 3.0 engine and it's being send the same way. And API doesn't
It's certainly not always sent by vmTests. And it would certainly be a nuisance to specify it on the command line. Can we make it 0-by-default, and update the docs accordingly?
Line 1818:         self.guestAgent = None
Line 1819:         self._guestEvent = 'Powering up'
Line 1820:         self._guestEventTime = 0
Line 1821:         self._vmStats = None


-- 
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list