Change in vdsm[master]: sp: move validatePoolSD in the StoragePool class
danken at redhat.com
danken at redhat.com
Mon Jan 13 19:50:08 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: sp: move validatePoolSD in the StoragePool class
......................................................................
Patch Set 7:
(1 comment)
Minor optimization that can wait for a later patch.
http://gerrit.ovirt.org/#/c/21787/7/vdsm/storage/sp.py
File vdsm/storage/sp.py:
Line 1011:
Line 1012: dom = sdCache.produce(sdUUID)
Line 1013:
Line 1014: # Avoid detach domains if not owned by pool
Line 1015: self.validatePoolSD(sdUUID)
Shouldn't this be better done before the produce() call?
Line 1016: self.validateAttachedDomain(dom)
Line 1017:
Line 1018: if sdUUID == self.masterDomain.sdUUID:
Line 1019: raise se.CannotDetachMasterStorageDomain(sdUUID)
--
To view, visit http://gerrit.ovirt.org/21787
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f0245ec5449d57431df7055be401d73975312b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list