Change in vdsm[master]: vdsm: Adding guest agent API versioning support

dougsland at redhat.com dougsland at redhat.com
Mon Jan 13 16:19:52 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Adding guest agent API versioning support
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File vdsm/guestIF.py:

Line 134:     def _validateAPIVersion(self, version):
Line 135:         try:
Line 136:             return int(version)
Line 137:         except ValueError:
Line 138:             self.log.error("Received invalid version value: %s", version)
> If I can make a suggestion based on the code and comments.
forgot to mention: I used api_version variable to have multiple points of return.
Line 139:             return 0
Line 140: 
Line 141:     def _setAPIVersion(self, version):
Line 142:         version = self._validateAPIVersion(version)


-- 
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list