Change in vdsm[master]: vdsm: Adding guest agent API versioning support
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Jan 13 13:02:06 UTC 2014
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 135: try:
Line 136: return int(version)
Line 137: except ValueError:
Line 138: self.log.error("Received invalid version value: %s", version)
Line 139: return 0
> 0 is supposed to be the lowest possible version, reporting the apiVersion a
worth a comment that you're resetting to the lowest
Line 140:
Line 141: def _setAPIVersion(self, version):
Line 142: version = self._validateAPIVersion(version)
Line 143: if version > _MAX_SUPPORTED_API_VERSION:
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9095b528c2c910f12d5f170088a458bf11c71910
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list