Change in vdsm[ovirt-3.3]: Removing unnecessary check-local from storage Makefile.am

ybronhei at redhat.com ybronhei at redhat.com
Mon Jan 13 09:36:34 UTC 2014


Hello Nir Soffer, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/23202

to review the following change.

Change subject: Removing unnecessary check-local from storage Makefile.am
......................................................................

Removing unnecessary check-local from storage Makefile.am

We used that to run storage_exception main [1] to verify the numeration of
the error code numbers. This section was removed from storage_exception
and is not needed anymore. Therefore this patch omits the redundant
check-local scope.

[1] http://gerrit.ovirt.org/#/c/2356/4/vdsm/storage/storage_exception.py

This fixes a regression introduced in commit ed426e5 which adds import
to zombiereaper in utils.py. With the removal of this check-local we
don't require zombiereaper during build time.

Change-Id: I81c634c3218ca6d21bce57fc9c500a906f8f0775
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23183
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/Makefile.am
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/23202/1

diff --git a/vdsm/storage/Makefile.am b/vdsm/storage/Makefile.am
index 2d3e9a6..f9cf9b3 100644
--- a/vdsm/storage/Makefile.am
+++ b/vdsm/storage/Makefile.am
@@ -70,6 +70,3 @@
 
 dist_vdsmexec_SCRIPTS = \
 	curl-img-wrap
-
-check-local:
-	PYTHONPATH="$(top_srcdir)/lib:$$PYTHONPATH" PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(srcdir)/storage_exception.py


-- 
To view, visit http://gerrit.ovirt.org/23202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81c634c3218ca6d21bce57fc9c500a906f8f0775
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list