Change in vdsm[master]: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

danken at redhat.com danken at redhat.com
Sun Jan 12 09:21:33 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test
......................................................................


BindingXMLRPC bugfix: Added netinfo:getDeviceByIP and a test

In essence a revert for http://gerrit.ovirt.org/#/c/21470/
I decided not to actually revert so that we keep the new getRouteTo
and its test, as its covered by a test and may be useful in the
future.

Both 'getDeviceByIP' and 'getRouteTo' solve the same issue:
How to report to the engine the device through which the last client
communicated to VDSM. This is used only in installation, so the
engine knows on what NIC to place the management bridge.

The getDeviceByIP approach gets the IP addr
of VDSM's side of the socket, and looks up the NIC which has that IP.
That had issues with testing (The changes can be seen in this patch).
getRouteTo's new (But flawed) approach was to route to the engine's
side of the socket. This failed in all-in-ones as it returned the
loopback device - It's not possible, nor does it make any sense
to place the management bridge on the loopback device.

Change-Id: I3563ae9b3e199e29ea2227463b9e4a3752cb99a0
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22841
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
M tests/netinfoTests.py
2 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3563ae9b3e199e29ea2227463b9e4a3752cb99a0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>


More information about the vdsm-patches mailing list