Change in vdsm[ovirt-3.3]: iscsi: Iscsi rescan cleanup

ybronhei at redhat.com ybronhei at redhat.com
Sun Jan 12 09:01:11 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: iscsi: Iscsi rescan cleanup
......................................................................


iscsi: Iscsi rescan cleanup

* Remove forceIscsiScan(): iscsiadm already does that when refreshing
  sessions
* Cleanup iscsi.rescan(): Replace complex logic with a simpler
  implementation since new iscsiadm takes care of all of this itself
* Make iscsi.rescan() more testable
* Test confusing timeout semantics of iscsi.rescan()

Bug-Url: https://bugzilla.redhat.com/964595
Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/21136
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M tests/Makefile.am
A tests/iscsiTests.py
M vdsm.spec.in
M vdsm/storage/iscsi.py
M vdsm/storage/iscsiadm.py
M vdsm/storage/multipath.py
M vdsm/supervdsmServer
7 files changed, 111 insertions(+), 62 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Saggi Mizrahi: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21136
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I842eb37cea3bd5e8cd357a310dd966081b242abd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list