Change in vdsm[master]: clientIF: Teardown volume path only for VDSM images

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 11 20:03:05 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................


Patch Set 5:

(2 comments)

....................................................
File vdsm/clientIF.py
Line 324:         return volPath
Line 325: 
Line 326:     def teardownVolumePath(self, drive):
Line 327:         res = {'status': doneCode}
Line 328: 
Lets first drop jump parameters like None and str:

    if drive is None or isinstance(drive, str):
        # Nothing to teardown
        return res
Line 329:         if vm.isVdsmImage(drive):
Line 330:             res = self.irs.teardownImage(drive['domainID'],
Line 331:                                          drive['poolID'], drive['imageID'])
Line 332:         return res['status']['code']


....................................................
File vdsm/vm.py
Line 86:     elif type(drive) is dict:
Line 87:         return all(k in drive.keys() for k in ('volumeID', 'domainID',
Line 88:                                                'imageID', 'poolID'))
Line 89:     else:
Line 90:         return False
Lets remove these changes from this patch, since master version already know how to handle both vm.Drive and dict.
Line 91: 
Line 92: 
Line 93: def _filterSnappableDiskDevices(diskDeviceXmlElements):
Line 94:         return filter(lambda(x): not(x.getAttribute('device')) or


-- 
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list