Change in vdsm[master]: misc: Log unhandled exception for new thread

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 11 19:22:49 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: misc: Log unhandled exception for new thread
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

....................................................
File vdsm/storage/misc.py
Line 885:             # happen. Wrapped methods should not throw
Line 886:             # exceptions, if this happens it's a bug
Line 887:             log.error("tmap caught an unexpected error", exc_info=True)
Line 888:             error[0] = e
Line 889:             resultsDict[index] = None
Exceptions in lines 887-889 will never be seen in the log without this patch. In this case, this can happen only when modifying this code.
Line 890: 
Line 891:     threads = []
Line 892:     for i, arg in enumerate(iterable):
Line 893:         t = threading.Thread(target=wrapper, args=(func, arg, i))


-- 
To view, visit http://gerrit.ovirt.org/23083
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id61236a8a2e546f80c23c86d878347f5bd98784d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list