Change in vdsm[master]: vdsm.spec: Add with_vhostmd
danken at redhat.com
danken at redhat.com
Fri Jan 10 12:55:05 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Add with_vhostmd
......................................................................
Patch Set 2:
(2 comments)
....................................................
Commit Message
Line 6:
Line 7: vdsm.spec: Add with_vhostmd
Line 8:
Line 9: The package vhostmd is only available on Fedora, the EL* version
Line 10: is not available.
not available on EPEL.
(you could still compile it yourself).
Line 11:
Line 12: Change-Id: Iffacf45abc2dfe866d4f3ea28e872a2fdddd69dc
....................................................
File vdsm.spec.in
Line 1174: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_vhostmd
Line 1175: %{_libexecdir}/%{vdsm_name}/hooks/before_vm_dehibernate/50_vhostmd
Line 1176: %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_vhostmd
Line 1177: %else
Line 1178: %exclude %{_sysconfdir}/sudoers.d/50_vdsm_hook_vhostmd
That's pretty ugly... Could you replace this by an --enable-hook-vhostmd option to the configure script, so that the files are never created?
If it takes too long, we can take the current version temporarily.
Line 1179: %exclude %{_libexecdir}/%{vdsm_name}/hooks/before_vm_start/50_vhostmd
Line 1180: %exclude %{_libexecdir}/%{vdsm_name}/hooks/before_vm_migrate_destination/50_vhostmd
Line 1181: %exclude %{_libexecdir}/%{vdsm_name}/hooks/before_vm_dehibernate/50_vhostmd
Line 1182: %exclude %{_libexecdir}/%{vdsm_name}/hooks/after_vm_destroy/50_vhostmd
--
To view, visit http://gerrit.ovirt.org/23126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffacf45abc2dfe866d4f3ea28e872a2fdddd69dc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list