Change in vdsm[master]: clientIF: replace type() with isinstance()

danken at redhat.com danken at redhat.com
Thu Jan 9 10:26:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: clientIF: replace type() with isinstance()
......................................................................


Patch Set 1: Code-Review-1

isinstance IS slightly "more pythonic" than type(), but Nir is correct in the fact that this patch fixes nothing, and as such, would better be avoided.

-- 
To view, visit http://gerrit.ovirt.org/23056
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic53afef3476a2aedbc5dac830a99f6ee9c093688
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list