Change in vdsm[master]: sp: split metadata transaction in createMaster

danken at redhat.com danken at redhat.com
Thu Jan 9 09:02:48 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sp: split metadata transaction in createMaster
......................................................................


sp: split metadata transaction in createMaster

This patch splits the createMaster metadata transactions in two parts:
one part related to the pool metadata initialization (with safe default
values) and the second one related to the domain metadata (including
role, masterVersion and attached pool).

The reason to split the two operations is to encapsulate the storage
pool metadata into methods that later on can be moved out of the
StoragePool class.

Removing the previous transaction is not risky as the pool metadata
values are safe defaults and the real commit phase is executed in the
domain metadata transaction. The two side effects of this change are:

- we always initialize the pool metadata even when the domain metadata
  transaction fails
- the createMaster operation takes now two storage operations instead
  of one

Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22418
Reviewed-by: Ayal Baron <abaron at redhat.com>
---
M vdsm/storage/sd.py
M vdsm/storage/sp.py
2 files changed, 27 insertions(+), 18 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Federico Simoncelli: Verified



-- 
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list