Change in vdsm[master]: sp: improve masterMigrate safety

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 9 08:54:16 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: sp: improve masterMigrate safety
......................................................................


Patch Set 3:

(1 comment)

....................................................
File vdsm/storage/sp.py
Line 866:                 os.path.join(newmsd.domaindir, sd.MASTER_FS_DIR),
Line 867:                 exclude=('./lost+found',))
Line 868: 
Line 869:             newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870:             self.switchMasterDomain(curmsd, newmsd, masterVersion)
swichMasterDomain is the last operation in this flow. After this operation, you cannot rollback. This function will implemented in the pool backends.

If changeRole succeeds, and switchMasterDomain fails, we are left with two domains set as master, but one will have valid pool meta data and one not. We are allready handling this situation in reconstructMaster.
Line 871:         except Exception:
Line 872:             self.log.exception('migration to new master failed')
Line 873:             newmsd.unmountMaster()
Line 874:             newmsd.releaseClusterLock()


-- 
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list