Change in vdsm[master]: vdsm: update size of LUN volume in prepareVolume

derez at redhat.com derez at redhat.com
Thu Jan 9 08:13:25 UTC 2014


Daniel Erez has posted comments on this change.

Change subject: vdsm: update size of LUN volume in prepareVolume
......................................................................


Patch Set 4:

(5 comments)

....................................................
File vdsm/clientIF.py
Line 108
Line 109
Line 110
Line 111
Line 112
done (looks like a rebase issue..)


....................................................
File vdsm/storage/hsm.py
Line 2991:             sdUUID=sdUUID).produceVolume(imgUUID=imgUUID,
Line 2992:                                          volUUID=volUUID).refreshVolume()
Line 2993: 
Line 2994:     @public
Line 2995:     def getVolumeSize(self, *args):
Yeah, the suggestion is to keep a common api (getVolumeSize) for both LUN devices and PDIV volumes. In case of LUN, the first argument should be a GUID.
Line 2996:         if len(args) == 1:
Line 2997:             return self.getLUVolumeSize(args[0])
Line 2998:         else:
Line 2999:             return self.getPDIVSize(args[0], args[1], args[2], args[3])


Line 2998:         else:
Line 2999:             return self.getPDIVSize(args[0], args[1], args[2], args[3])
Line 3000: 
Line 3001:     @public
Line 3002:     def getLUVolumeSize(self, devGUID, options=None):
Yeah, I'm passing drive["GUID"] now and not the full path
Line 3003:         """
Line 3004:         Gets the size of a LUN device volume.
Line 3005: 
Line 3006:         :param volPath: The LUN device volume path.


Line 3002:     def getLUVolumeSize(self, devGUID, options=None):
Line 3003:         """
Line 3004:         Gets the size of a LUN device volume.
Line 3005: 
Line 3006:         :param volPath: The LUN device volume path.
Done
Line 3007:         :type volPath: string
Line 3008: 
Line 3009:         :returns: a dict with the size of the volume.
Line 3010:         :rtype: dict


Line 3012:         size = str(multipath.getDeviceSize(devicemapper.getDmId(devGUID)))
Line 3013: 
Line 3014:         return dict(truesize=size, apparentsize=size)
Line 3015: 
Line 3016:     @public
Yeah, I guess we shouldn't expose it now - will convert to private.
Line 3017:     def getPDIVSize(self, sdUUID, spUUID, imgUUID, volUUID, options=None):
Line 3018:         """
Line 3019:         Gets the size of a volume.
Line 3020: 


-- 
To view, visit http://gerrit.ovirt.org/22976
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48b4343c6519fed366beec415c47226d4e3c8fef
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list