Change in vdsm[master]: vm: set self._dom to None after destroying vm

Jarod.w work.iec23801 at gmail.com
Wed Jan 8 03:51:33 UTC 2014


Jarod.w has posted comments on this change.

Change subject: vm: set self._dom to None after destroying vm
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 4511:                                           "gracefully", self.conf['vmId'])
Line 4512:                             time.sleep(30)
Line 4513:                             self._dom.destroy()
Line 4514:                     finally:
Line 4515:                             self._dom = None
When getting VIR_DOMAIN_EVENT_STOPPED_SHUTDOWN/DESTROYED signals, we can think that it has been successfully destroyed, right? If so, we
might need to set self._dom None in _onQemuDeath.
Line 4516:             except libvirt.libvirtError as e:
Line 4517:                 if e.get_error_code() == libvirt.VIR_ERR_NO_DOMAIN:
Line 4518:                     self.log.warning("libvirt domain not found", exc_info=True)
Line 4519:                 else:


-- 
To view, visit http://gerrit.ovirt.org/23014
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eca4c14e44a2a95628bf8e45a7a0a64d56446b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jarod.w <work.iec23801 at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list