Change in vdsm[master]: Gluster API verbs will now be callable again

amuller at redhat.com amuller at redhat.com
Tue Jan 7 15:29:26 UTC 2014


Assaf Muller has posted comments on this change.

Change subject: Gluster API verbs will now be callable again
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 79:         self.server.server_close()
Line 80:         self._thread.join()
Line 81:         return {'status': doneCode}
Line 82: 
Line 83:     @staticmethod
Ok we had a mid-air collision between comments.

About static vs module level, here's my 2 cents: So in Python there's no real point to static methods because you can just put them at the module level... It's just a semantics thing. Putting it in the class suggests what is its relevant scope. In this specific case it makes more sense to me (as a reader) for the function to belong to the BindingXMLRPC class.
Line 84:     def updateTimestamp():
Line 85:         # FIXME: The setup+editNetwork API uses this log file to
Line 86:         # determine if this host is still accessible.  We use a
Line 87:         # file (rather than an event) because setup+editNetwork is


-- 
To view, visit http://gerrit.ovirt.org/23044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibab01ef654e7ac469ea0a2594c4744918ae24819
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list