Change in vdsm[master]: sp: refresh metadata on hsm when listing domains

nsoffer at redhat.com nsoffer at redhat.com
Tue Jan 7 10:09:58 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: sp: refresh metadata on hsm when listing domains
......................................................................


Patch Set 4: -Code-Review

(3 comments)

After talking with Federico, it is clear now. What seemed like 3 different changes are actually 3 related changes, which are not explained in the commit message.

While we can split the changes to different patches, I think that practically we should keep this patch as is, since Federico has more patches building on it.

The code looks good, waiting for a clear commit message.

....................................................
File vdsm/storage/sp.py
Line 528
Line 529
Line 530
Line 531
Line 532
Lets keep this in this patch.


Line 536
Line 537
Line 538
Line 539
Line 540
Lets keep this in this patch.


Line 536:             poolMeta[PMDK_MASTER_VER] = masterVersion
Line 537:             domain.changeRole(role)
Line 538: 
Line 539:     # TODO: Remove or rename this function.
Line 540:     def validatePoolSD(self, sdUUID):
Now its clear.
Line 541:         if sdUUID not in self.getDomains():
Line 542:             raise se.StorageDomainNotMemberOfPool(self.spUUID, sdUUID)
Line 543:         return True
Line 544: 


-- 
To view, visit http://gerrit.ovirt.org/21786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I095cd0760076fb4be97a776498af78a40ff84112
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list