Change in vdsm[master]: [WIP]add simple balloon functional testcase

msivak at redhat.com msivak at redhat.com
Tue Jan 7 09:47:07 UTC 2014


Martin Sivák has posted comments on this change.

Change subject: [WIP]add simple balloon functional testcase
......................................................................


Patch Set 2:

(1 comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 190: 
Line 191:         with RollbackContext() as rollback:
Line 192:             self._runVMKernelBootTemplate(rollback, customization)
Line 193:             self._enableBalloonPolicy(policy, rollback)
Line 194:             time.sleep(12)  # MOM policy engine wake up evey 10s
and *wakes :)

The period is configured using the config file, so it might be possible to configure the test environment to use different config file with lower numbers.

Or we might replace time.sleep in MoM with threading.Event and add an explicit trigger() function that will reevaluate immediately.
Line 195:             balloonInf = self.s.getVmStats(
Line 196:                 customization['vmId'])['statsList'][0]['balloonInfo']
Line 197:             self.assertEqual(balloonInf['balloon_cur'], 0)
Line 198: 


-- 
To view, visit http://gerrit.ovirt.org/12820
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list