Change in vdsm[master]: gluster: Get size information of a gluster volume

tjeyasin at redhat.com tjeyasin at redhat.com
Tue Jan 7 09:07:25 UTC 2014


Timothy Asir has posted comments on this change.

Change subject: gluster: Get size information of a gluster volume
......................................................................


Patch Set 8:

(1 comment)

....................................................
File client/vdsClientGluster.py
Line 457:         params = self._eqSplit(args)
Line 458:         volumeName = params.get('volumeName', '')
Line 459:         if not volumeName:
Line 460:             raise ValueError('volumeName is required parameter')
Line 461: 
vdsmcli also treated as a functional testing tool.
We need to test the state (of glusterVolumeStatsInfoGet) when engine calls this funciton without volumeName. So, this volumeName null check should be there inside the glusterVolumeStatsInfoGet function.
Line 462:         status = self.s.glusterVolumeStatsInfoGet(volumeName)
Line 463:         pp.pprint(status)
Line 464:         return status['status']['code'], status['status']['message']
Line 465: 


-- 
To view, visit http://gerrit.ovirt.org/17822
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I358d4f3bf793ecc1a01e0592d68919d1405f6e19
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi at gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list