Change in vdsm[master]: API: Replace try-except block with @traceback

danken at redhat.com danken at redhat.com
Mon Jan 6 18:01:13 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: API: Replace try-except block with @traceback
......................................................................


API: Replace try-except block with @traceback

waitForPid thread was using an explicit try except block for
reporting excpetions.
The patch replaces it with the @traceback decorator,
ensuring that exceptions are logged and simplifying the
code.

Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22813
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/API.py
1 file changed, 18 insertions(+), 20 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit http://gerrit.ovirt.org/22813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list