Change in vdsm[master]: [RFE] set the # of vcpus for a VM (hot plug/unplug)
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Mon Jan 6 14:07:17 UTC 2014
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
......................................................................
Patch Set 15:
(1 comment)
....................................................
File vdsm/vm.py
Line 897: memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 898: self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 899: self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)
Line 900: vcpu = self.dom.appendChildWithArgs(
Line 901: 'vcpu', text=self.conf.get('maxVCpus', '160'))
I'd suggest to not modify legacy flows and use "smp" in case maxVCpus is not specified
Line 902: # hotplug cpu requires a maximum number which is higher than the static
Line 903: # assignment. 160 is the max number of cpu's for a guest
Line 904: # see http://www.ovirt.org/Hot_plug_cpu
Line 905: vcpu.setAttrs(**{'current': self.conf['smp'], 'placement': 'static'})
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list