Change in vdsm[master]: hooks: Extract devName function for openstacknet

danken at redhat.com danken at redhat.com
Mon Jan 6 10:35:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Extract devName function for openstacknet
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

....................................................
File vdsm_hooks/openstacknet/openstacknet_utils.py
Line 25:                            (command, err))
Line 26: 
Line 27: 
Line 28: def devName(prefix, name):
Line 29:     return (prefix + str(name))[:DEV_MAX_LENGTH]
why do we need the str() call?


-- 
To view, visit http://gerrit.ovirt.org/22584
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ece3bb16ac5b9bb8b28c26f2e96d2d74defd4dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list