Change in vdsm[master]: bootstrap: Return recovery error until hsm is ready

abaron at redhat.com abaron at redhat.com
Sun Jan 5 20:29:08 UTC 2014


Ayal Baron has posted comments on this change.

Change subject: bootstrap: Return recovery error until hsm is ready
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/storage/dispatcher.py
Line 92: class Dispatcher:
Line 93:     log = logging.getLogger('Storage.Dispatcher')
Line 94: 
Line 95:     def __init__(self, obj):
Line 96:         self._obj = obj
why save _obj and not move the 'ready' snippet in here?
i.e.
self.ready = ...
Line 97:         self.storage_repository = config.get('irs', 'repository')
Line 98:         self._exposeFunctions(obj)
Line 99:         self.log.info("Starting StorageDispatcher...")
Line 100: 


-- 
To view, visit http://gerrit.ovirt.org/21530
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id74468917c5b7c05d4183854e2f1255de98325dc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list