Change in vdsm[master]: API: Replace try-except block with @traceback

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 5 19:21:43 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: API: Replace try-except block with @traceback
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

Commit message needs some more love.

....................................................
Commit Message
Line 7: API: Replace try-except block with @traceback
Line 8: 
Line 9: waitForPid thread was using an explicit try except block for
Line 10: reporting excpetions.
Line 11: 
Both sentences can be in the same paragraph.
Line 12: This patch replaces with the @traceback decorator,
Line 13: ensuring that excretions are logged and simplifying the
Line 14: code.
Line 15: 


Line 8: 
Line 9: waitForPid thread was using an explicit try except block for
Line 10: reporting excpetions.
Line 11: 
Line 12: This patch replaces with the @traceback decorator,
replaces it with
Line 13: ensuring that excretions are logged and simplifying the
Line 14: code.
Line 15: 
Line 16: Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639


Line 9: waitForPid thread was using an explicit try except block for
Line 10: reporting excpetions.
Line 11: 
Line 12: This patch replaces with the @traceback decorator,
Line 13: ensuring that excretions are logged and simplifying the
s/excretions/exceptions/
Line 14: code.
Line 15: 
Line 16: Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639


-- 
To view, visit http://gerrit.ovirt.org/22813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list