Change in vdsm[master]: Validate VDSM user's sudoer permissions

Alon Bar-Lev alonbl at redhat.com
Sun Jan 5 16:16:43 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Validate VDSM user's sudoer permissions
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/vdsm
Line 171:         # This cmd choice is arbitrary to validate that sudoes.d/50_vdsm file
Line 172:         # is read properly
Line 173:         cmd = [constants.EXT_CHOWN, constants.VDSM_USER,
Line 174:                constants.QEMU_PROCESS_GROUP, dst]
Line 175:         rc, _, stderr = utils.execCmd(cmd, sudo=True)
just stupid comment... as vdsm runs under vdsm user anyway... this is void... as temp file already has this permissions.... it just like "sudo chown --help" :)
Line 176: 
Line 177:     if rc != 0:
Line 178:         syslog.syslog("vdsm user could not manage to run sudo operation: "
Line 179:                       "(stderr: %s). Verify sudoer rules configuration" %


-- 
To view, visit http://gerrit.ovirt.org/22888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: sasha.chuzhoy at gmail.com
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list