Change in vdsm[master]: BindingXMLRPC bugfix: Return lastClientIface for current con...

danken at redhat.com danken at redhat.com
Sun Jan 5 14:22:09 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BindingXMLRPC bugfix: Return lastClientIface for current connection
......................................................................


BindingXMLRPC bugfix: Return lastClientIface for current connection

The patch does two things:
1) Fixes a bug where lastClientIface was for the previous
   connection, and not the current one. The method to retrieve
   the last client was through a log_request LoggingMixIn
   which is invoked at the end of a response, not at the beginning.
   The patch removes the usage of that MixIn, and instead uses
   values that are updated at the beginning of the connection
2) Simplifies the 'LoggingMixin' out of the picture as its no
   longer needed

Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22837
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 15 insertions(+), 19 deletions(-)

Approvals:
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22837
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list