Change in vdsm[master]: [3/x] Bugfix: Return lastClientIface for *current* connection
amuller at redhat.com
amuller at redhat.com
Sun Jan 5 12:46:19 UTC 2014
Assaf Muller has posted comments on this change.
Change subject: [3/x] Bugfix: Return lastClientIface for *current* connection
......................................................................
Patch Set 1:
(2 comments)
....................................................
Commit Message
Line 3: AuthorDate: 2013-12-31 14:02:49 +0200
Line 4: Commit: Assaf Muller <amuller at redhat.com>
Line 5: CommitDate: 2013-12-31 14:02:49 +0200
Line 6:
Line 7: [3/x] Bugfix: Return lastClientIface for *current* connection
I improved the commit message. I couldn't find an explicit bug for this, but that doesn't rule out the possibility of a bug that happens because of the current behavior. I couldn't find such bugs either case.
As for backporting - I was thinking of backporting the entire chain, not just the 2 patches fixing actual bugs. (Remember I wanted exactly 2 patches, one for each bug). I know we don't normally backport cleanups, but I think for this case it'll be trivial to backport the entire chain but difficult to backport only 2 out of 5 patches.
Line 8:
Line 9: Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
....................................................
File vdsm/BindingXMLRPC.py
Line 86: # file (rather than an event) because setup+editNetwork is
Line 87: # performed by a separate, root process. To clean this
Line 88: # up we need to move this to an API wrapper that is only
Line 89: # run for real clients (not vdsm internal API calls).
Line 90: file(constants.P_VDSM_CLIENT_LOG, 'w')
Done
Line 91:
Line 92: def _getKeyCertFilenames(self):
Line 93: """
Line 94: Get the locations of key and certificate files.
--
To view, visit http://gerrit.ovirt.org/22837
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36e48cc07a27f44a2b413f0e9159110404f1b0ca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list