Change in vdsm[master]: hooks: Extract function for command execution

danken at redhat.com danken at redhat.com
Sun Jan 5 10:25:52 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Extract function for command execution
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File vdsm_hooks/openstacknet/openstacknet_utils.py
Line 19: 
Line 20: 
Line 21: def executeOrExit(command):
Line 22:     retcode, out, err = hooking.execCmd(command, sudo=True, raw=True)
Line 23:     if retCode != 0:
Python is case sensitive...
Line 24:         raise RuntimeError("Failed to execute %s, due to: %s" %


-- 
To view, visit http://gerrit.ovirt.org/22583
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0bcc3be324d1afd9855f9d624cbe4efbf3cf6dd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list