Change in vdsm[master]: tests: validate cdrom path sent to/received from vdsm

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri Jan 3 08:20:20 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: tests: validate cdrom path sent to/received from vdsm
......................................................................


Patch Set 1:

(2 comments)

I'd like to see a follow-up test about vmPayload as well...

....................................................
File tests/functional/virtTests.py
Line 271:                                          deviceDef['hotplugDisk']), timeout=10)
Line 272:                 self.retryAssert(partial(self.vdsm.hotunplugDisk,
Line 273:                                          deviceDef['hotplugDisk']), timeout=10)
Line 274: 
Line 275:     @permutations([['self'], ['specParams'], ['both']])
or hotplug/unplug. It shouldn't matter much where it fails as long as it fails.
Line 276:     def testVmWithCdrom(self, pathLocation):
Line 277:         fd, path = tempfile.mkstemp()
Line 278:         os.chmod(path, 0o644)
Line 279: 


Line 289:         else:
Line 290:             # we can use the same path to avoid having to generate another
Line 291:             # tmpfile
Line 292:             cdrom['path'] = path
Line 293:             cdrom['specParams']['path'] = path
that's what I mean, just use some nonsense in specparams to be sure it's not taken into account instead of path
Line 294: 
Line 295:         customization = {'vmId': '77777777-ffff-3333-bbbb-222222222222',
Line 296:                          'vmName': 'testVm', 'devices': [cdrom]}
Line 297: 


-- 
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I620c481056f7ee3b4d3270ba1f4bc45cbb132ebb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list