Change in vdsm[master]: API: Log unhandled exception for new Thread

danken at redhat.com danken at redhat.com
Thu Jan 2 23:56:59 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: API: Log unhandled exception for new Thread
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-12-30 11:52:42 +0200
Line 4: Commit:     Maor Lipchuk <mlipchuk at redhat.com>
Line 5: CommitDate: 2014-01-02 13:37:31 +0200
Line 6: 
Line 7: API: Log unhandled exception for new Thread
The existing code already logs unhandled exceptions. You code is better, since it's shorter and more generic, but this commit message is misleading.
Line 8: 
Line 9: Adding a traceback log when openning a new thread in the Global class, so it
Line 10: will not die silently when fails.
Line 11: 


-- 
To view, visit http://gerrit.ovirt.org/22813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c618bd52f276d23c7f90742f690d20f45a6639
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list