Change in vdsm[master]: [4/x] Added netinfo:getDeviceByIP and a test

danken at redhat.com danken at redhat.com
Thu Jan 2 23:21:43 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: [4/x] Added netinfo:getDeviceByIP and a test
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
Commit Message
Line 3: AuthorDate: 2013-12-31 14:37:15 +0200
Line 4: Commit:     Assaf Muller <amuller at redhat.com>
Line 5: CommitDate: 2013-12-31 15:33:57 +0200
Line 6: 
Line 7: [4/x] Added netinfo:getDeviceByIP and a test
I know the sad motivation for this patch (our current implementation returns "lo" for all local addresses). But this has to be specified in the commit message, too.

You should mention that this is practically a revert.
Line 8: 
Line 9: Change-Id: I3563ae9b3e199e29ea2227463b9e4a3752cb99a0


-- 
To view, visit http://gerrit.ovirt.org/22841
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3563ae9b3e199e29ea2227463b9e4a3752cb99a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list