Change in vdsm[master]: Validate VDSM user's sudoer permissions

danken at redhat.com danken at redhat.com
Thu Jan 2 16:26:17 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Validate VDSM user's sudoer permissions
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

....................................................
File vdsm/vdsm
Line 174:                constants.QEMU_PROCESS_GROUP, dst]
Line 175:         rc, _, _ = utils.execCmd(cmd, sudo=True)
Line 176: 
Line 177:     if rc != 0:
Line 178:         syslog.syslog("User VDSM has invalid sudoer rules configuration")
there's slight chance that chown has failed due to something else. We should be less sure in that statement, and even include stderr, just in case.
Line 179:         sys.exit(1)
Line 180: 
Line 181: 
Line 182: if __name__ == '__main__':


-- 
To view, visit http://gerrit.ovirt.org/22888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: sasha.chuzhoy at gmail.com
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list