Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

majopela at redhat.com majopela at redhat.com
Thu Jan 2 09:22:57 UTC 2014


Miguel Angel Ajo Pelayo has posted comments on this change.

Change subject: vdsm: allow hooks to pass down dictionaries in json format
......................................................................


Patch Set 6:

(1 comment)

....................................................
File tests/functional/networkTests.py
Line 1560:                     network_config = json.load(cookie_file)
Line 1561:                     self.assertTrue('networks' in network_config, True)
Line 1562:                     self.assertTrue('bondings' in network_config, True)
Line 1563:                     self.assertTrue(NETWORK_NAME in network_config['networks'],
Line 1564:                                     True)
At this moment, when I check this, networks is empty 

We call the hook with:
 running_config = netconfpersistence.RunningConfig()	
hooks.after_network_setup({'networks': running_config.networks,
			                 'bondings': running_config.bonds})

What does RunningConfig provide, and when is it updated?
Line 1565: 
Line 1566:                 delete_networks = {NETWORK_NAME: {'remove': True}}
Line 1567:                 self.vdsm_net.setupNetworks(delete_networks,
Line 1568:                                             {}, {})


-- 
To view, visit http://gerrit.ovirt.org/20330
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Miguel Angel Ajo Pelayo <majopela at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majopela at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list