Change in vdsm[master]: utilsTests: Avoiding returning in the middle of the method

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 1 17:35:53 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: utilsTests: Avoiding returning in the middle of the method
......................................................................


Patch Set 1:

(1 comment)

The commit message should be improved - see comments.

....................................................
Commit Message
Line 6: 
Line 7: utilsTests: Avoiding returning in the middle of the method
Line 8: 
Line 9: In RollbackContextTest there are some tests which returns in the first
Line 10: except. This patch avoids that.
I think that the description is bad; the purpose of this patch is to clarify the code. There is no problem to return in the middle of the function, and it is even good in most cases. But in this case using try: except: else: make the code little more clear.
Line 11: 
Line 12: Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8


-- 
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I877f65569f4304bdd4160bb9f84facf261e568e8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list