Change in vdsm[master]: Adding verifying of sudoers config
ybronhei at redhat.com
ybronhei at redhat.com
Wed Jan 1 16:52:04 UTC 2014
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding verifying of sudoers config
......................................................................
Adding verifying of sudoers config
Must be specified in sudoers to include sudoers.d this for reading
vdsm.conf for sudo operations. Without it vdsm cannot start properly
Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1024236
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M init/vdsmd_init_common.sh.in
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/22888/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 071b9a6..22fcaae 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -22,6 +22,15 @@
prog=vdsm
#### pre-start tasks ####
+
+task_sudoerd_config() {
+ if ! "@GREP_PATH@" "#includedir /etc/sudoers.d" /etc/sudoers; then
+ echo "cannot run vdsm without #includedir /etc/sudoers.d specified " \
+ "in /etc/sudoers"
+ return 1
+ fi
+ return 0
+}
task_configure_coredump() {
local conf_file="@CONFDIR@/vdsm.conf"
local getconfitem="@VDSMDIR@/get-conf-item"
@@ -219,6 +228,7 @@
--pre-start)
run_tasks " \
mkdirs \
+ sudoerd_config \
configure_coredump \
run_init_hooks \
gencerts \
--
To view, visit http://gerrit.ovirt.org/22888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b1cb66e927f7ed0fcdd1898edd59730322cdeb1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
More information about the vdsm-patches
mailing list