Change in vdsm[master]: misc: Fix exception re-rasing in RollbackContext
vvolansk at redhat.com
vvolansk at redhat.com
Wed Jan 1 12:22:06 UTC 2014
Vered Volansky has posted comments on this change.
Change subject: misc: Fix exception re-rasing in RollbackContext
......................................................................
Patch Set 3:
(3 comments)
....................................................
File tests/miscTests.py
Line 1140: self.fail("Wrong exception was raised")
Line 1141:
Line 1142: self.fail("Exception was not raised")
Line 1143:
Line 1144: def testKeyErrorException(self):
Done
Line 1145: """
Line 1146: KeyError is raised as a tuple and not expection. Re-rasing it
Line 1147: should be aware of this fact and handled carfully.
Line 1148: """
Line 1142: self.fail("Exception was not raised")
Line 1143:
Line 1144: def testKeyErrorException(self):
Line 1145: """
Line 1146: KeyError is raised as a tuple and not expection. Re-rasing it
Done
Line 1147: should be aware of this fact and handled carfully.
Line 1148: """
Line 1149: try:
Line 1150: with misc.RollbackContext():
Line 1153: return
Line 1154: except Exception:
Line 1155: self.fail("Wrong exception was raised")
Line 1156:
Line 1157: self.fail("Exception was not raised")
I prefer to do it in another patch.
Line 1158:
Line 1159:
Line 1160: class FindCallerTests(TestCaseBase):
Line 1161: def _assertFindCaller(self, callback):
--
To view, visit http://gerrit.ovirt.org/22860
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0052717e2307ad6fec2225b3ad5f438c5a60e1c6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list