Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

nsoffer at redhat.com nsoffer at redhat.com
Wed Jan 1 10:57:58 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
......................................................................


Patch Set 4:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 55: 
Line 56: from cpopen import CPopen
Line 57: from . import constants
Line 58: 
Line 59: # Buffsize is 1K because it was tested on some use cases and 1K was fastest. If
+1 for using the comment suggested by Allon :-)
Line 60: # you find this number to be a bottleneck in any way you are welcome to change
Line 61: # it
Line 62: BUFFSIZE = 1024
Line 63: 


-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list