Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

amureini at redhat.com amureini at redhat.com
Wed Jan 1 10:47:16 UTC 2014


Allon Mureinik has posted comments on this change.

Change subject: utils: cleanup - typos, grammar and comments refinement
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

....................................................
File lib/vdsm/utils.py
Line 55: 
Line 56: from cpopen import CPopen
Line 57: from . import constants
Line 58: 
Line 59: # Buffsize is 1K because it was tested on some use cases and 1K was fastest. If
Frankly, I think this is comment is useless no matter how you fix the grammar.
"some use cases" gives about as much information as "this number was presented to me by David Beckham during a lucid dream"
Line 60: # you find this number to be a bottleneck in any way you are welcome to change
Line 61: # it
Line 62: BUFFSIZE = 1024
Line 63: 


Line 982:         Returns the result as a tuple of (result, error).
Line 983:         If the operation is still running it will block until it returns.
Line 984: 
Line 985:         If no resultParser has been set the default result
Line 986:         is (rc, out, err) """
According to the convention you established in this patch, the trailing """ should be moved to its own line
Line 987:         with self._lock:
Line 988:             if self._result is None:
Line 989:                 out, err = self._proc.communicate()
Line 990:                 rc = self._proc.returncode


-- 
To view, visit http://gerrit.ovirt.org/22862
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a1c4d444f2604b66b44bb9deac7d780db04aaf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list