Change in vdsm[master]: set the # of vcpus for a VM (hot plug/unplug)
rgolan at redhat.com
rgolan at redhat.com
Wed Jan 1 06:49:26 UTC 2014
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
......................................................................
Patch Set 11:
(2 comments)
....................................................
File tests/vmTests.py
Line 45: 'function': '0x0', 'type': 'pci'}
Line 46:
Line 47: def __init__(self, *args, **kwargs):
Line 48: TestCaseBase.__init__(self, *args, **kwargs)
Line 49: self.maxDiff = None
this is for the assertMultiLineEqual to show the full diff of xml incase there is a mismatch
Line 50: self.conf = {'vmName': 'testVm',
Line 51: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f',
Line 52: 'smp': '8', 'memSize': '1024', 'memGuaranteedSize': '512'}
Line 53:
....................................................
File vdsm/API.py
Line 455: return errCode['noVM']
Line 456:
Line 457: return curVm.hotunplugDisk(params)
Line 458:
Line 459: def setNumberOfCpus(self, vmId, numberOfCpus):
I use it only for input parameter validation here for this section is shared with vdsClient.py and BinfingXMLRPC and potentially every other client.
Line 460:
Line 461: if vmId is None or numberOfCpus is None:
Line 462: self.log.error(
Line 463: 'Missing one of required parameters: vmId, numberOfCpus')
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief35e1d335737cd98d21a5413ac9f8ab9d824c3e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list