Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
osvoboda at redhat.com
osvoboda at redhat.com
Fri Feb 28 22:47:57 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
......................................................................
Patch Set 5:
(1 comment)
OK, I will change the test the same way.
http://gerrit.ovirt.org/#/c/25170/5/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 695: for netInfo in d['networks'].itervalues():
Line 696: if netInfo['bridged']:
Line 697: netInfo['cfg']['BOOTPROTO'] = netInfo['bootproto4']
Line 698:
Line 699: else:
> You should drop the "else". Bridged networks has cfg both in the network AN
Aaah, my bad, of course, the former comes from _getNetInfo() and the latter from _devinfo() through _bridgeinfo()...
Line 700: for devType in ('bondings', 'bridges', 'nics', 'vlans'):
Line 701: dev = d[devType].get(netInfo['iface'])
Line 702:
Line 703: if dev:
--
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list