Change in vdsm[master]: netinfo: remove code duplication between nics, bridges, bond...
danken at redhat.com
danken at redhat.com
Fri Feb 28 22:41:50 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: remove code duplication between nics, bridges, bonds and vlans
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/24174/10/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:
Line 237: (self.isVF() and self._isVFhidden()))
Line 238: elif self.isBOND():
Line 239: return anyFnmatch(self.name, self._hiddenBonds)
Line 240: elif self.isBRIDGE():
Line 241: return self.name == DUMMY_BRIDGE
oops, I've missed that != in my review
Line 242: return False
Line 243:
Line 244: def _isVFhidden(self):
Line 245: if self.address == '00:00:00:00:00:00':
--
To view, visit http://gerrit.ovirt.org/24174
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c54801822d487bde7f0e4ba9e79bf278e2a7598
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list