Change in vdsm[master]: netinfo: Retrieve bonding options differing from defaults

danken at redhat.com danken at redhat.com
Thu Feb 27 13:28:38 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

minor comment.

http://gerrit.ovirt.org/#/c/24456/10/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1162:             self.assertBondExists(BONDING_NAME, bondDict['nics'])
Line 1163: 
Line 1164:             # See if live options (read from sysfs) match those requested
Line 1165:             cfg = self.vdsm_net.netinfo.bondings[BONDING_NAME]['cfg']
Line 1166:             self.assertEqual(cfg['BONDING_OPTS'], bondDict['options'])
using set(split()) on both sides would be more elegant than forcing everybody to sort their options.
Line 1167: 
Line 1168:         with dummyIf(3) as nics:
Line 1169:             with self.vdsm_net.pinger():
Line 1170:                 # Add initial vlanned net over bond


-- 
To view, visit http://gerrit.ovirt.org/24456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list