Change in vdsm[master]: vm: consider 'action' when handling I/O errors

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Feb 27 12:42:09 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: vm: consider 'action' when handling I/O errors
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 552:                 srcPath, devAlias, action, reason = args[:-1]
Line 553:                 if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 554:                     v._onAbnormalStop(devAlias, reason)
Line 555:                 else:
Line 556:                     self.log.warn('I/O error event on %s (%s) reason %s'
since the only other supported action is "report"(to the guest), wouldn't it make more sense to just say so in the log…and only on any other action code log a warning or error?
Line 557:                                   ' ignored due to action %i',
Line 558:                                   srcPath, devAlias, reason, action)
Line 559:             elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 560:                 phase, localAddr, remoteAddr, authScheme, subject = args[:-1]


-- 
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list