Change in vdsm[master]: net_scale: Don't instantiate NetInfo needlessly
danken at redhat.com
danken at redhat.com
Thu Feb 27 09:56:51 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: net_scale: Don't instantiate NetInfo needlessly
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
http://gerrit.ovirt.org/#/c/23576/8/vdsm/configNetwork.py
File vdsm/configNetwork.py:
Line 445: raise ConfigNetworkError(ne.ERR_BAD_PARAMS, 'Cannot specify '
Line 446: 'any attribute when removing')
Line 447:
Line 448: currentBondings = netinfo.bondings()
Line 449: currentNicsSet = set(netinfo.nics())
hey, It could be a fozenset()! but enough with that.
Line 450: for bonding, bondingAttrs in bondings.iteritems():
Line 451: Bond.validateName(bonding)
Line 452: if 'options' in bondingAttrs:
Line 453: Bond.validateOptions(bonding, bondingAttrs['options'])
--
To view, visit http://gerrit.ovirt.org/23576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I729c522396095a8114fefbc600dab00b46cea2bb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list