Change in vdsm[master]: net tests: more combinations mtu combinations

asegurap at redhat.com asegurap at redhat.com
Wed Feb 26 18:12:34 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: net tests: more combinations mtu combinations
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

For forwards consistency.

http://gerrit.ovirt.org/#/c/19230/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1157:         self.assertEquals(status, SUCCESS, msg)
Line 1158:         self.assertNetworkExists(netName, bridged=bridged)
Line 1159:         self.assertBondExists(BONDING_NAME, bondDict['nics'])
Line 1160:         if 'mtu' in networkOpts:
Line 1161:             self.assertEquals(networkOpts['mtu'],
Would you mind rebasing on top of http://gerrit.ovirt.org/#/c/25003/5 and reusing it's self.assertMtu?
Line 1162:                               self.vdsm_net.getMtu(netName))
Line 1163: 
Line 1164:     @cleanupNet
Line 1165:     @permutations([[True], [False]])


-- 
To view, visit http://gerrit.ovirt.org/19230
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list