Change in vdsm[master]: make vlan speed reporting show the vlan underlying device speed

danken at redhat.com danken at redhat.com
Wed Feb 26 15:17:51 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: make vlan speed reporting show the vlan underlying device speed
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I find the commit message a bit misleading.

http://gerrit.ovirt.org/#/c/24990/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: make vlan speed reporting show the vlan underlying device speed
Line 8: 
Line 9: vdsm was reporting speed 0 for the vlan devices and letting the
Line 10: engine put a default value of 1000mbps for them. This patch
afaict Engine does not have this logic. it is sampling.py  that assumes speed=1000 if speed is undefined.
Line 11: increases the level of information that reaches the engine by
Line 12: making the vlan reported speed be its maximum theoretical speed,
Line 13: i.e., the speed of the device which provides link to it.
Line 14: 


-- 
To view, visit http://gerrit.ovirt.org/24990
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee7f1ea72c77bb628640c1b2b27aac51811c8b0d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list